Skip to content

[Dashboard] [Controls]: Changed default text for option list #143413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2022
Merged

[Dashboard] [Controls]: Changed default text for option list #143413

merged 2 commits into from
Oct 18, 2022

Conversation

arpitbhardwaj
Copy link
Contributor

Summary

The default text for options list is changed from "Select..." to "Any". Refer #141144

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

NA

For maintainers

@arpitbhardwaj arpitbhardwaj requested a review from a team as a code owner October 15, 2022 10:20
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ThomThomson ThomThomson added release_note:fix Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0 labels Oct 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor

buildkite test this

@Heenawter Heenawter linked an issue Oct 17, 2022 that may be closed by this pull request
[Dashboard] [Controls] Change default options list text to "Any" #141144
Closed
ThomThomson
ThomThomson approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, i18n changes LGTM!

@ThomThomson
Copy link
Contributor

buildkite test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
controls 26.5KB 26.4KB -6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@ThomThomson ThomThomson merged commit 34ad684 into elastic:main Oct 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 18, 2022
kc13greiner pushed a commit to kc13greiner/kibana that referenced this pull request Oct 18, 2022
@arpitbhardwaj @kc13greiner
Changed default test for option list (elastic#143413)
cbb297c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community Feature:Input Control Input controls visualization Project:Controls release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] [Controls] Change default options list text to "Any"
5 participants
@arpitbhardwaj @kibanamachine @elasticmachine @ThomThomson @kibana-ci