Skip to content

[Lens] embeddable warnings placement looks pretty bad with a metric. #144368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 1, 2022

Closes: #144027

Summary

This PR applies UI suggestions from #144027 (comment)

Screen

localhost_5620_app_dashboards

@alexwizp alexwizp force-pushed the lens-fix-warning-messages branch from 36a63de to 10e841b Compare November 3, 2022 15:56
@alexwizp alexwizp force-pushed the lens-fix-warning-messages branch from 10e841b to 6984ced Compare November 8, 2022 11:46
@alexwizp alexwizp self-assigned this Nov 8, 2022
@alexwizp alexwizp added v8.6.0 Feature:Lens Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) release_note:fix labels Nov 8, 2022
@alexwizp
Copy link
Contributor Author

alexwizp commented Nov 8, 2022

@elasticmachine merge upstream

@alexwizp alexwizp marked this pull request as ready for review November 8, 2022 13:54
@alexwizp alexwizp requested a review from a team as a code owner November 8, 2022 13:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected in all cases I encountered - LGTM
Screenshot 2022-11-08 at 15 22 53

@alexwizp alexwizp enabled auto-merge (squash) November 8, 2022 14:30
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
charts 250 252 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB -19.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 45.4KB 45.8KB +454.0B
Unknown metric groups

API count

id before after diff
charts 265 267 +2

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 8c29a47 into elastic:main Nov 8, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] embeddable warnings placement looks pretty bad with a metric.
5 participants