Skip to content

[Lens] Exclude the reference layer from the cursor sync hook #144384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 2, 2022

Summary

Closes #144380

As described on the issue the bug exists when you have a Lens chart with a reference layer and the Group by this field switch set to true.

The problem is that the reference layer is a very specific layer that messes with the useCursorSync hook logic. There is no need to use these layers for this functionality. What we need here to decide if this chart should sync or not the cursor are the data layers.

dashboard

@stratoula stratoula added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) Feature:Lens backport:skip This commit does not require backporting v8.6.0 labels Nov 2, 2022
@stratoula stratoula marked this pull request as ready for review November 2, 2022 08:35
@stratoula stratoula requested a review from a team as a code owner November 2, 2022 08:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 118.7KB 118.8KB +28.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 445 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 522 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@stratoula stratoula merged commit 9e58af5 into elastic:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Sync cursor not applies with reference lines and a breakdown with "Group by this field first"
4 participants