-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[ML] Adding cloud trial end date to ml info #144793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adding cloud trial end date to ml info #144793
Conversation
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Would be great to extend to the KibanaContextProvider
with this info as well
Yes, that's a good idea. Outside of the scope of this PR, but I can add it in a follow up. |
Adds a
isCloudTrial
flag to ML's/api/ml/info
endpoint.If
xpack.cloud.trial_end_date
is set in the kibana config and it is greater than the current time, we can assume that we're currently in a could trial.If
xpack.cloud.trial_end_date
is not set,isCloudTrial
is not added to the endpoint response. This is the same behaviour as thecloudId
property.Adds a
isCloudTrial()
function to our server info util functions which can be used in conjunction with ourisCloud()
function.To test, these cloud settings can be added to the kibana config: