[Exploratory View] adjust formula for synthetics monitor availability #144868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/uptime (Team:uptime) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
shahzad31
approved these changes
Nov 9, 2022
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dominiqueclarke
added a commit
to dominiqueclarke/kibana
that referenced
this pull request
Nov 10, 2022
…elastic#144868) Resolves elastic#143672 (cherry picked from commit 1fdf78f) # Conflicts: # x-pack/plugins/observability/public/components/shared/exploratory_view/configurations/lens_attributes.ts
dominiqueclarke
added a commit
that referenced
this pull request
Nov 10, 2022
…bility (#144868) (#145026) # Backport This will backport the following commits from `main` to `8.5`: - [[Exploratory View] adjust forumla for synthetics monitor availability (#144868)](#144868) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2022-11-09T09:23:25Z","message":"[Exploratory View] adjust forumla for synthetics monitor availability (#144868)\n\nResolves https://github.com/elastic/kibana/issues/143672","sha":"1fdf78ff8ee7fbfeaeb2544a8c7c4210d956572f","branchLabelMapping":{"^v8.6.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:uptime","v8.6.0","v8.5.1"],"number":144868,"url":"https://github.com/elastic/kibana/pull/144868","mergeCommit":{"message":"[Exploratory View] adjust forumla for synthetics monitor availability (#144868)\n\nResolves https://github.com/elastic/kibana/issues/143672","sha":"1fdf78ff8ee7fbfeaeb2544a8c7c4210d956572f"}},"sourceBranch":"main","suggestedTargetBranches":["8.5"],"targetPullRequestStates":[{"branch":"main","label":"v8.6.0","labelRegex":"^v8.6.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/144868","number":144868,"mergeCommit":{"message":"[Exploratory View] adjust forumla for synthetics monitor availability (#144868)\n\nResolves https://github.com/elastic/kibana/issues/143672","sha":"1fdf78ff8ee7fbfeaeb2544a8c7c4210d956572f"}},{"branch":"8.5","label":"v8.5.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
Changing |
|
@mistic if it's not in 8.5.1, we should remove it from the release notes. https://www.elastic.co/guide/en/kibana/8.5/release-notes-8.5.1.html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #143672
Adds global summary filter to availability metric
Also fixes an error where an invalid
orderByattribute was being applied to formula columns, causing invalid aggregation errors.Testing