Skip to content

[Uptime] Allow using AND for tags filtering #145079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 15, 2022
Merged

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 14, 2022

Summary

Fixes #132308

Allow using AND for tags filtering

image

@shahzad31 shahzad31 changed the title use AND for tags [Uptime] Allow using AND for tags filtering Nov 14, 2022
@shahzad31 shahzad31 marked this pull request as ready for review November 14, 2022 16:20
@shahzad31 shahzad31 requested a review from a team as a code owner November 14, 2022 16:20
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@awahab07
Copy link
Contributor

If only the operator is changed, date doesn't update. Date should reload if only the operator is switched.

Switch-operator-not-work.mov

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 enabled auto-merge (squash) November 15, 2022 17:07
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 487.7KB 490.8KB +3.1KB
synthetics 1.1MB 1.1MB +2.7KB
total +5.8KB
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 882a1a1 into elastic:main Nov 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 15, 2022
@shahzad31 shahzad31 deleted the tag-and branch November 15, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Support AND and OR operators for tag filter selection
5 participants