Skip to content

Increase download and upload buffers. #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

dopiera
Copy link
Contributor

@dopiera dopiera commented Aug 7, 2019

This fixes #2657.

Experiments, which back these numbers are described in #2657.


This change is Reviewable

This fixes googleapis#2657.

Experiments, which back these numbers are described in googleapis#2657.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2019
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #2945 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2945      +/-   ##
==========================================
- Coverage   90.56%   90.56%   -0.01%     
==========================================
  Files         298      298              
  Lines       20148    20172      +24     
==========================================
+ Hits        18248    18268      +20     
- Misses       1900     1904       +4
Impacted Files Coverage Δ
google/cloud/storage/client_options.cc 92.59% <100%> (ø) ⬆️
...oogle/cloud/bigtable/internal/unary_client_utils.h 82.14% <0%> (-17.86%) ⬇️
google/cloud/storage/internal/complex_option.h 66.66% <0%> (-16.67%) ⬇️
google/cloud/storage/well_known_headers.h 70.37% <0%> (-3.71%) ⬇️
google/cloud/storage/well_known_parameters.h 68.88% <0%> (-3.34%) ⬇️
google/cloud/storage/internal/object_requests.h 97.01% <0%> (-2.99%) ⬇️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 64.15% <0%> (-1.24%) ⬇️
google/cloud/bigtable/internal/bulk_mutator.cc 90.21% <0%> (-1.09%) ⬇️
google/cloud/storage/internal/logging_client.cc 97.76% <0%> (-0.02%) ⬇️
google/cloud/bigtable/row_range.h 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b319bea...0d2c68c. Read the comment docs.

@coryan coryan merged commit 389a5e0 into googleapis:master Aug 7, 2019
@dopiera dopiera deleted the increase_buffers branch August 28, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase default buffer sizes for storage uploads and downloads.
3 participants