Improve Positron integration #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update tinyAxis to account for DateTime to
This was referenced Apr 21, 2025
This was referenced May 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
I know there are quite a few file changes here, but the key ones are simply wrapping
recordGraphicsaround (inside?)draw_legend()anddraw_facet_window().The other changes are just downstream of that (e.g., better documentation and argument passing of internal functions), as well as some improvements to the panel grid logic that I caught during testing (i.e., when
grid = TRUE).MWE
Bad Positron pic example (old code)
Good Positron pic example (new code with this PR)