Applying the pending render state can't ever be executed

[svillar]

The current algorithm for XR animation frame will always result in an abort on step 5 unless I'm missing something.

Step 5 aborts is the base layer of the active render state is null which is the default value. The base layer of the active render state is only set when the pending state is applied. However that step is the last step of the XR animation frame algorithm, meaning that it won't ever be executed because we're early returning before on step 5.

I've checked for example Chromium's implementation and they're running the apply very early just after receiving frame data.

[toji]

Thanks for pointing that out! This was a recent change, so Chromium is still using the older timing.

I'll push out a pull request to fix it soon.

[Manishearth]

For reference, we broke this in #1111 , i think we just need to handle the null case properly again