-
Notifications
You must be signed in to change notification settings - Fork 406
Add [SameObject] to all applicable readonly attributes #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
index.bs
Outdated
readonly attribute XRLayer? baseLayer; | ||
readonly attribute XRPresentationContext? outputContext; | ||
[SameObject] readonly attribute XRLayer? baseLayer; | ||
[SameObject] readonly attribute XRPresentationContext? outputContext; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two attributes are the only ones I question in this change, because it implies that each time the render state changes the session attribute will be a new object. That's actually not a bad assumption to make, and it's probably preferable to having XRRenderState
be a live object, but I'd like to get that clearly defined one way or the other in the spec prior to adding a dependency on that behavior here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, hm, that's fair. I'll remove that and file an issue
Looks great, thank you! I have one change request but otherwise I'm happy to merge this. You are correct about the |
Done. |
Should I leave a note on XRBoundedReferenceSpace that Also I added in two uncommitted SameObject changes that I'd forgotten to push: |
Hm......... |
Yeah, I was a bit iffy about that one too |
Nope, actually |
Fixes #588
There are only two non-primitive
readonly attribute
s that this does not affect:XRSession.renderState
: This can be updated withupdateRenderState()
XRBoundedReferenceSpace.boundsGeometry
: I'm unsure if this array can be updated if settings changer? @toji