Skip to content

ProgressEvent() constructor options loaded + total accept double in Chrome 136 + Firefox 138 #26956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2025

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jun 2, 2025

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Jun 2, 2025
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@bsmth
Copy link
Member Author

bsmth commented Jun 2, 2025

I'm open to suggestions whether this should be one entry under the constructor - I'm thinking this might make more sense as:

"description": "`loaded` and `total` accept decimal values",

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data looks good to me, but:

  1. The term "decimals" could be misleading here (cf. decimal list type). Let's use double as mentioned in the spec.
  2. Since loaded and total are readonly, I would say this is more a feature of the constructor. Let's add one behavioral subfeature there instead: api.ProgressEvent.ProgressEvent.loaded_total_options_accept_double.

@bsmth
Copy link
Member Author

bsmth commented Jun 2, 2025

Great, tnx. Agree on both points.

@bsmth bsmth requested a review from caugner June 3, 2025 07:51
bsmth and others added 2 commits June 3, 2025 13:46
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@bsmth bsmth requested a review from caugner June 3, 2025 11:46
@caugner caugner changed the title ProgressEvent can use decimals for loaded and total ProgressEvent() constructor options loaded + total accept double in Chrome 136 + Firefox 138 Jun 3, 2025
Co-authored-by: Brian Smith <brian@smith.berlin>
@caugner caugner enabled auto-merge (squash) June 3, 2025 15:57
@caugner caugner merged commit 4e6b477 into mdn:main Jun 3, 2025
6 checks passed
@bsmth bsmth deleted the mdn-641 branch June 3, 2025 15:59
@bsmth
Copy link
Member Author

bsmth commented Jun 3, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants