-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ProgressEvent()
constructor options loaded
+ total
accept double in Chrome 136 + Firefox 138
#26956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
I'm open to suggestions whether this should be one entry under the constructor - I'm thinking this might make more sense as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data looks good to me, but:
- The term "decimals" could be misleading here (cf. decimal list type). Let's use
double
as mentioned in the spec. - Since
loaded
andtotal
are readonly, I would say this is more a feature of the constructor. Let's add one behavioral subfeature there instead:api.ProgressEvent.ProgressEvent.loaded_total_options_accept_double
.
Great, tnx. Agree on both points. |
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
ProgressEvent()
constructor options loaded
+ total
accept double in Chrome 136 + Firefox 138
Co-authored-by: Brian Smith <brian@smith.berlin>
Thank you! |
Summary
Test results and supporting details
WPT: https://wpt.fyi/results/xhr/progressevent-constructor.html?label=master&label=stable&product=chrome&product=firefox&product=safari&product=edge&aligned
Related issues