Add source.fixAll constant #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. |
rchl
reviewed
Jul 2, 2021
Comment on lines
+6686
to
+6691
| * Base kind for an organize imports source action: | ||
| * `source.fixAll`. | ||
| * | ||
| * Fix all actions automatically fix errors that have a clear fix that | ||
| * do not require user input. They should not suppress errors or perform | ||
| * unsafe fixes such as generating new types or classes. |
There was a problem hiding this comment.
Some copy-paste and wording issues:
This is wrong:
Base kind for an organize imports source action:
This sentence doesn't start well:
Fix all actions automatically fix errors
There was a problem hiding this comment.
Eugh, good catch. The second part was copy/pasted from VS Code so I didn't want to change it too much. I've added quotes around 'Fix all' that I think make it clearer - I've filed #1309 - comments welcome. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dbaeumer I don't know if this is reasonable, but VS Code has a constant for it and it seems like it would be useful for the same reason as having
source.organizeImportshere - so clients can provide better UI beyond just the Source Actions list for invoking this kind of (common) operation.