Search only returns first 10,000 items found

[nyghtly-derek]

Issue Type: Bug

1. Open file containing more than 10,000 instances of a string such as "hello,"
2. Search for "hello,"
3. Only 10,000 results will be found

VS Code version: Code 1.41.1 (26076a4, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz (2 x 2400)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: disabled_off oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: unavailable_off skia_renderer: disabled_off surface_control: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	9.00GB (1.83GB free)
Process Argv	file.txt
Screen Reader	no
VM	100%

Extensions (4)

Extension	Author (truncated)	Version
gc-excelviewer	Gra	2.1.32
mssql	ms-	1.8.0
csharp	ms-	1.21.11
powershell	ms-	2020.1.0

I'm aware of existing issues such as #8563

What makes my issue unique is that it properly identifies this search limitation as a bug. The search module does not indicate anywhere that there is a limit to the number of results that will be returned. Thus it is a reasonable for the user to assume that the search module will return all possible results.

Either this bug needs to be fixed, or a warning needs to be added when the results limit is reached. As is stands a user might believe that they are getting all the results, even though they are not.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• search results have a limit of 10000 items (#29120)
• Increase the number of cursors from 10000 (#81589)

[nyghtly-derek]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• search results have a limit of 10000 items (#29120)
• Increase the number of cursors from 10000 (#81589)

From original bug report:

I'm aware of existing issues such as https://github.com//issues/8563

What makes my issue unique is that it properly identifies this search limitation as a bug. The search module does not indicate anywhere that there is a limit to the number of results that will be returned. Thus it is a reasonable for the user to assume that the search module will return all possible results.

Either this bug needs to be fixed, or a warning needs to be added when the results limit is reached. As is stands a user might believe that they are getting all the results, even though they are not.

[JacksonKearl]

Are you referring to the in-editor search, or the entire workspace search?

[nyghtly-derek]

@JacksonKearl - The entire workspace search. I didn't test ctrl-f on the individual file.

The reason I discovered this in the first place is because I was trying to find-and-replace all instances of a string in my file. Other editors like notepad++ can do it no problem.

[JacksonKearl]

You should see a warning like:

Do you not?

[nyghtly-derek]

I will attempt this again and report back with a screenshot...

…

On Wed, Feb 12, 2020, 10:28 AM Jackson Kearl ***@***.***> wrote: You should see a warning like: [image: image] <https://user-images.githubusercontent.com/8586769/74365178-61326000-4d82-11ea-8d36-5ba47fdff99d.png> Do you not? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#90383?email_source=notifications&email_token=ABXSEPWTGQM5QI7RTM54HPDRCQ5UTA5CNFSM4KSSOEL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELR34AA#issuecomment-585350656>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABXSEPQ6ZV56MRP55M76A2LRCQ5UTANCNFSM4KSSOELQ> .

[nyghtly-derek]

I received no such warning.

A comparison of the search methods:

Unable to search and replace all instances of "hello," with "hello,goodbye":

[roblourens]

Yeah, we don't correctly compute whether to show that warning when the max is hit in an open file. And actually the editor doesn't tell us whether the result was hit, so we will have to ask for max+1 results and work it out from that.