Emmet: Select next/previous item does not work with script tag. #118842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
reviewed
Mar 18, 2021
rzhao271
reviewed
Mar 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #113515
Issue: Emmet select does not work with html script tags.
Reason: The reason is that the html subtree corresponding to the script tag is not generated and as a result, emmet does not select into the script tag.
Fix: Whenever we are fetching the HTML node corresponding to a position, if we end up in fetching a script tag, then we would set up the the script node subtree and then again fetch the HTML node corresponding to the same position. This way we would be able to parse/select contents which are child of the <script> tags.
Validations: Verified that the scenario mentioned in the tag is working after these changes + other manual verification of select next/previous item.