[typescript-language-features] Support import statement completions for TypeScript 4.3 #119009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Looks good to me! Will merge once the TS side of the fix is merged. VS Code endgame starts next week, so we'd probably want to target 1.56 insiders |
andrewbranch
commented
Mar 22, 2021
| @@ -5,6 +5,8 @@ | |||
| "configuration.typescript": "TypeScript", | |||
| "configuration.suggest.completeFunctionCalls": "Complete functions with their parameter signature.", | |||
| "configuration.suggest.includeAutomaticOptionalChainCompletions": "Enable/disable showing completions on potentially undefined values that insert an optional chain call. Requires TS 3.7+ and strict null checks to be enabled.", | |||
| "configuration.suggest.includeCompletionsForImportStatements": "Enable/disable auto-import-style completions on partially-typed import statements. Requires using TypeScript 4.3+ in the workspace.", | |||
| "configuration.suggest.includeCompletionsWithSnippetText": "Enable/disable snippet completions from TS Server. Requires using TypeScript 4.3+ in the workspace.", | |||
There was a problem hiding this comment.
Updated to add an explicit option for snippet-formatted completions, since clients that don’t expect them would insert literal $1 instead of tab stops.
There was a problem hiding this comment.
Just as a future note: This is the first example where TS Server uses snippets, but I have a long standing TS issue about using snippets in more places: microsoft/TypeScript#25207
|
@mjbvz the TS PR is merged. Feel free to merge this one whenever you’re ready. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart of microsoft/TypeScript#43149 (cc @mjbvz)