Skip to content

Fixes simple browser icons are broken in firefox #120275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

jeanp413
Copy link
Contributor

Not a CSP expert but firefox doesn't like the full URL for font-src

<meta
http-equiv="Content-Security-Policy"
content="default-src 'none';
	font-src https://55582f46-d0e8-47cd-9fee-99526b57ac58.vscode-webview-test.com/0d728c31ebdf03869d2687d9be0b017667c9ff37/vscode-resource/http//localhost%3A8080/static/extensions/simple-browser/media/codicon.ttf;
	style-src https://*.vscode-webview-test.com;
	script-src 'nonce-1617229294534534';
	frame-src *;
">

This PR fixes #120036

@mjbvz mjbvz added this to the April 2021 milestone Apr 6, 2021
@mjbvz mjbvz merged commit 8117fec into microsoft:main Apr 6, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 6, 2021

Thanks!

@jeanp413 jeanp413 deleted the fix-120036 branch April 6, 2021 22:45
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[simple browser] icons are broken in firefox
2 participants