Skip to content

Add emmet self closing abbreviation support #120311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Add emmet self closing abbreviation support #120311

merged 1 commit into from
Apr 1, 2021

Conversation

sangxxh
Copy link
Contributor

@sangxxh sangxxh commented Apr 1, 2021

This PR fixes #120203

JSX:

120203_20210401_JSX After

HTML:

120203_20210401_After

sangxxh
sangxxh commented Apr 1, 2021
View reviewed changes
rzhao271
rzhao271 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@rzhao271 rzhao271 merged commit 595a894 into microsoft:main Apr 1, 2021
@sangxxh sangxxh deleted the issue/120203-emmet-no-suggestion-self-closing-abbrev branch April 1, 2021 20:53
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues polish Cleanup and polish issue labels Apr 5, 2021
@rzhao271 rzhao271 added this to the April 2021 milestone Apr 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

+1 more reviewer

@pixieaka pixieaka pixieaka left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues polish Cleanup and polish issue
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.

Emmet suggestion fails to show when user writes self-closing abbreviation
3 participants
@sangxxh @rzhao271 @pixieaka