Skip to content

Refactor npm extension to only use npm #120317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Apr 1, 2021

This PR fixes #120315

I planned to add a video of me trying these changes but it's been a few weeks already since I wrote the code and didn't manage to do the recording, so I figured out it was still more important to create this PR to not let the code go stale.

@ghost
Copy link

ghost commented Apr 1, 2021

CLA assistant check
All CLA requirements met.

@chrmarti chrmarti assigned aeschli and unassigned mjbvz Apr 1, 2021
@aeschli aeschli added this to the April 2021 milestone Apr 6, 2021
@aeschli aeschli added the json JSON support issues label Apr 6, 2021
@aeschli aeschli merged commit 05de366 into microsoft:main Apr 6, 2021
@aeschli
Copy link
Contributor

aeschli commented Apr 6, 2021

Thanks a lot, @Jolg42!

@Jolg42 Jolg42 deleted the npm-ext-use-npm-only branch April 16, 2021 08:19
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
json JSON support issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using api.npms.io in npm VS Code extension and only use npm registry for reliability & privacy
3 participants