Fix race condition in showing and hiding suggestWidget #121396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
jrieken
requested changes
Apr 16, 2021
b913dea to
a8551c4
Compare
|
@jrieken I made the suggested change |
a8551c4 to
3595082
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes microsoft/monaco-editor#2437
If suggestions are triggered by typing, typing causes the suggest widget be shown and then hidden as the typing initially matches some suggestions but then no suggestions. However, a race condition might happen because there is a 100ms timeout for showing the widget, but hiding is immediate. This change fixes the issue by cancelling the show timeout when hiding the widget.