Modified markdown preview nested list styling #124445
Conversation
| @@ -132,6 +132,9 @@ p { | |||
| } | |||
|
|
|||
| ul, | |||
| ul{ | |||
There was a problem hiding this comment.
Should all unordered list have no bottom margin, or only lists inside of other lists?
There was a problem hiding this comment.
Hii@mjbvz what do you suggest should be appropriate?
There was a problem hiding this comment.
I'd keep the existing rule and add new rules the zero the bottom margin for ul ul { (and probably ul ol, ol ul, ol, ol too, although please test those out to see what they look like first)
There was a problem hiding this comment.
@mjbvz Ok, I will do the same, thanks!
| @@ -105,6 +105,18 @@ body.showEditorSelection li.code-line:hover:before { | |||
| .vscode-high-contrast.showEditorSelection .code-line .code-line:hover:before { | |||
| border-left: none; | |||
| } | |||
| ul ul{ | |||
There was a problem hiding this comment.
[nit] Can you please merge these into a single rule separated by commas instead. It makes the intent of this rule more clear
| ul ul{ | ||
| margin-bottom: 0%; | ||
| } | ||
| ul ol{ |
There was a problem hiding this comment.
[nit] Just use 0 instead of 0%. They mean the same thing but zero without units is much more common
|
@mjbvz Would you please review and let me know if further changes are to be made :) |
|
Thanks! Will be in the next insiders build and is scheduled to be part of VS Code 1.57 |
This PR fixes #124419