Update select to matching bracket direction #128931

ssigwart · 2021-07-18T04:00:50Z

This PR fixes #128930.

This selected from the end to start position when selecting to matching bracket.

Automated tests

./scripts/test.sh --glob **/bracketMatching.test.js

Select from the } (using editor.action.selectToBracket) in this, then use Shift + Up:

// Shift+ up
function shiftUpTest()
{
	var i = 0
}

Select to matching bracket when the cursor is within the </div> (using editor.emmet.action.balanceOut) in this, then use Shift + Up:

<html>
	<body>
		<div>
			<h1>Test</h1>
		</div>
	</body>
</html>

rzhao271 · 2021-07-19T19:10:41Z

The Emmet part of the diff looks good to me!
I'll let @alexdima review the rest.

Update select to matching bracket direction

e2dbe97

vscode-triage-bot assigned rzhao271 Jul 18, 2021

rzhao271 requested review from rzhao271 and alexdima July 19, 2021 19:01

rzhao271 added this to the July 2021 milestone Jul 19, 2021

rzhao271 modified the milestones: July 2021, August 2021 Jul 30, 2021

alexdima added 2 commits August 17, 2021 14:57

Merge remote-tracking branch 'origin/main' into pr/ssigwart/128931

2fbaf20

simplify proposed changes

0826a8b

alexdima approved these changes Aug 17, 2021

View reviewed changes

alexdima merged commit 58b670c into microsoft:main Aug 17, 2021

ssigwart deleted the matchBrace branch August 18, 2021 00:52

github-actions bot locked and limited conversation to collaborators Oct 1, 2021