Skip to content

Fixed vertical alignment #130327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Fixed vertical alignment #130327

merged 3 commits into from
Aug 12, 2021

Conversation

yash112-lang
Copy link
Contributor

@yash112-lang yash112-lang commented Aug 7, 2021

@TylerLeonhardt please take a look at the changes😀.

Before -

image

After -

image

This PR fixes #124382

@rzhao271 rzhao271 requested a review from TylerLeonhardt August 9, 2021 14:52
@TylerLeonhardt TylerLeonhardt added this to the August 2021 milestone Aug 9, 2021
@TylerLeonhardt TylerLeonhardt added the quick-pick Quick-pick widget issues label Aug 9, 2021
@yash112-lang
Copy link
Contributor Author

@Tyriar, @TylerLeonhardt, @rzhao271, is there any mistake in the code? because it is not merged till now. I'm new to this project so can you help me with this?

@TylerLeonhardt
Copy link
Member

You're good @yash112-lang. I just have a lot on my plate at the moment. There are a couple things I want you to test with your change before I merge it in. Specifically:

  • Progress in the quick pick

    • Example: Install the Remote Repositories extension and Open a GitHub Repository you get this progress bar (see the purple bar that runs across the quick pick if this were animated):
      image
  • Instead of -5ing can you just change the padding for quick-input-widget that has 6 padding bottom at the moment (it's in that file you modified)

@yash112-lang
Copy link
Contributor Author

Thanks, @TylerLeonhardt for the suggestions, I had done the changes that you suggested, I had also checked for the:

Progress in the quick pick

  • Example: Install the Remote Repositories extension and Open a GitHub Repository you get this progress bar (see the purple bar that runs across the quick pick if this were animated):

and it is working fine. Is any other improvement in the code needed?

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

Thank you for your contribution!

@TylerLeonhardt TylerLeonhardt merged commit 418ae29 into microsoft:main Aug 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
quick-pick Quick-pick widget issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick pick vertical alignment is off
2 participants