Bug in occ_search in scientificName synonym lookup block

[sckott]

From user email:

occ_search(scientificName='Corynorhinus townsendii ingens', config=verbose())
#> ...
#> /v1/occurrence/search?limit=500&offset=0
#> ...

isn't passing in the scientifcName parameter - it's being set to NULL so ignored.

already identified problem, fixing soon

happening here https://github.com/ropensci/rgbif/blob/master/R/occ_search.r#L278-L285

[sckott]

hmm, there's far too many scenarios to deal with in this case, leading to potentially endless bugs given the vast number of names, and the likely changing nature of the GBIF backbone taxonomy

thus, removing the synonym checker.

In addition, GBIF I think didn't used to automatically search against the accepted name for the name input to scientificName, but now they seem to do that. So I think the API is automatically doing what we were doing manually, but removing our code means far fewer bugs

[sckott]

Some egs

(test <- occ_search(scientificName='Corynorhinus townsendii ingens'))
(test2 <- occ_search(scientificName='Corynorhinus townsendii'))
(test3 <- occ_search(scientificName='Corynorhinus'))
(test4 <- occ_search(scientificName = "Myotis septentrionalis septentrionalis"))
(test4_1 <- occ_search(scientificName = "Myotis septentrionalis"))
(test5 <- occ_search(scientificName = "Parastrellus hesperus"))
(test6 <- occ_search(scientificName = 'Pulsatilla patens'))
(test7 <- occ_search(scientificName = 'Perimyotis subflavus')) # wrong genus, need to lookup name first
(test8 <- occ_search(scientificName = 'Myotis ciliolabrum'))
(test9 <- occ_search(scientificName = 'Lasiurus xanthinus'))

Also, egs in tests at https://github.com/ropensci/rgbif/blob/master/tests/testthat/test-occ_search.r#L147-L194

[sckott]

done