-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
A-config-cliArea: --config CLI optionArea: --config CLI optionC-bugCategory: bugCategory: bugS-triageStatus: This issue is waiting on initial triage.Status: This issue is waiting on initial triage.regression-from-stable-to-stableRegression in stable that worked in a previous stable release.Regression in stable that worked in a previous stable release.
Description
Problem
As reported in renovatebot/renovate#29277
- Private git repo dependency fetching worked on 1.77 but not 1.78
- They used
net.git-fetch-with-cli=true
on the command-line
I git bisected it to #13479, specifically f525e1f
Steps
$ git clone https://github.com/crate-ci/cargo-release.git
$ cd cargo-release
$ rm -rf ~/.cargo/git # avoiding the github fast path
$ cargo update --config net.git-fetch-with-cli=true
Notice that the fetch is done using libgit2 instead of git. To make this more obvious, I ran from master with a dbg!
around the git_fetch_with_cli
check at
cargo/src/cargo/sources/git/utils.rs
Line 1008 in d04355a
if let Some(true) = gctx.net_config()?.git_fetch_with_cli { |
Possible Solution(s)
No response
Notes
No response
Version
No response
Metadata
Metadata
Assignees
Labels
A-config-cliArea: --config CLI optionArea: --config CLI optionC-bugCategory: bugCategory: bugS-triageStatus: This issue is waiting on initial triage.Status: This issue is waiting on initial triage.regression-from-stable-to-stableRegression in stable that worked in a previous stable release.Regression in stable that worked in a previous stable release.