#1103 Fixed small issues with N-BEATS and N-HITS #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iso self.num_stacks. Also adjusted the API reference docs
Codecov Report
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 93.75% 93.75% -0.01%
==========================================
Files 80 80
Lines 8157 8144 -13
==========================================
- Hits 7648 7635 -13
Misses 509 509
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hrzn
reviewed
Aug 8, 2022
CHANGELOG.md
Outdated
| @@ -34,6 +34,7 @@ Darts is still in an early development phase and we cannot always guarantee back | |||
| - An issue with arguments being reverted for the `metric` function of gridsearch and backtest [#989](https://github.com/unit8co/darts/pull/989) by [Clara Grotehans](https://github.com/ClaraGrthns). | |||
| - An error checking whether `fit()` has been called in global models [#944](https://github.com/unit8co/darts/pull/944) by [Julien Herzen](https://github.com/hrzn). | |||
| - An error in Gaussian Process filter happening with newer versions of sklearn [#963](https://github.com/unit8co/darts/pull/963) by [Julien Herzen](https://github.com/hrzn). | |||
| - An issue where num_stacks is used instead of self.num_stacks in the NBEATSModel. Also, a few mistakes in API reference docs [#1103](https://github.com/unit8co/darts/pull/1103) by [Rijk van der Meulen](https://github.com/rijkvandermeulen) | |||
There was a problem hiding this comment.
+1 for adding an entry, however you should add it under the Unreleased section (not the already-release 0.20.0 version).
There was a problem hiding this comment.
Oh my bad, of course. I've changed it.
| @@ -760,7 +759,7 @@ def __init__( | |||
| self.num_stacks = 2 | |||
|
|
|||
| if isinstance(layer_widths, int): | |||
| self.layer_widths = [layer_widths] * num_stacks | |||
| self.layer_widths = [layer_widths] * self.num_stacks | |||
There was a problem hiding this comment.
Could you also bring the same fix to nhits.py ?
| @@ -574,7 +574,6 @@ def __init__( | |||
| The number of blocks making up every stack. | |||
| num_layers | |||
| The number of fully connected layers preceding the final forking layers in each block of every stack. | |||
| Only used if `generic_architecture` is set to `True`. | |||
There was a problem hiding this comment.
Could you also change the docstring of _NBEATSModule ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where num_stacks is used instead of self.num_stacks in the NBEATSModel. Also addresses a few mistakes in API reference docs.
Summary
Other Information
Fixed an unrelated minor typo somewhere else in the docs