Implement map method for TimeSeries #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An implementation for map is added. It uses pandas' applymap method. A jupyter notebook to show the tests conducted. Resolves: #121
|
@Lovkush-A Thanks for your PR! I like your approach but have a couple of comments:
|
Unit tests test_map.py added. Included a small check, that the indices are in a valid range, in map method in TimeSeries class.
|
@pennfranc
|
hrzn
reviewed
Jul 22, 2020
|
|
||
| def map(self, | ||
| fn: Callable[[float], float], | ||
| cols: Optional[Union[List[int], int]] = None) -> 'TimeSeries': |
There was a problem hiding this comment.
@grll you'll probably have to change this as part of you refactoring
There was a problem hiding this comment.
yes we would need to replace int indexing with str indexing but nothing too serious here
Following hrzn's advice, various minor adjustments were made: * Correct various spacing/wording inconsistencies * Move contents of test_map.py into test_timeseries.py * Added sanity test case to tests for map * Changed type hints to np.number * Removed an unncessary call to self.pd_dataframe()
TheMP
approved these changes
Jul 23, 2020
TheMP
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Summary
An implementation for map is added. It uses pandas' applymap method.
A jupyter notebook is included to show the tests conducted.
Other Information
I have added a couple of TODOs: