Skip to content

Refactor/transformer masking #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

dennisbader
Copy link
Collaborator

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2398

Summary

  • Significant speed ups for all DataTransformers when using a large number of time series: The component masking logic was moved into the parallelized transform methods.

@dennisbader dennisbader requested a review from madtoinou as a code owner June 4, 2024 13:58
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 97.40260% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.75%. Comparing base (a4ed8b1) to head (9290757).

Current head 9290757 differs from pull request most recent head 1d996ed

Please upload reports for the commit 1d996ed to get more accurate results.

Files Patch % Lines
...taprocessing/transformers/base_data_transformer.py 96.72% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
- Coverage   93.75%   93.75%   -0.01%     
==========================================
  Files         138      138              
  Lines       14355    14370      +15     
==========================================
+ Hits        13459    13473      +14     
- Misses        896      897       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 05f6ddf into master Jun 5, 2024
@dennisbader dennisbader deleted the refactor/transformer_masking branch June 5, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Scaler took a long time to start fit
2 participants