Skip to content

revert back to saving and loading a TFM with torch rather than pickle #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Feb 23, 2025

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2687, fixes #2681

Summary

  • fixes errors when loading a torch model that was trained on another device, than the one that is loaded on
  • revert back to saving / loading the TFM wrapper with torch rather than pickle

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (4de0868) to head (925a2bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
- Coverage   94.17%   94.09%   -0.08%     
==========================================
  Files         141      141              
  Lines       15579    15582       +3     
==========================================
- Hits        14671    14662       -9     
- Misses        908      920      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 8bea071 into master Feb 24, 2025
9 checks passed
@dennisbader dennisbader deleted the fix/tfm_load branch February 24, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants