Remove extra convolutions in TCN #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darts/models/tcn_model.py
Outdated
| @@ -84,7 +84,7 @@ def __init__(self, | |||
| if weight_norm: | |||
| self.conv1, self.conv2 = nn.utils.weight_norm(self.conv1), nn.utils.weight_norm(self.conv2) | |||
|
|
|||
| if nr_blocks_below == 0 or nr_blocks_below == num_layers - 1: | |||
| if nr_blocks_below in {0, num_layers - 1} and input_dim != output_dim: | |||
There was a problem hiding this comment.
Actually do you think we could simplify this to
Suggested change
| if nr_blocks_below in {0, num_layers - 1} and input_dim != output_dim: | |
| if input_dim != output_dim: |
There was a problem hiding this comment.
Agree! Looks super simple and clear
darts/models/tcn_model.py
Outdated
| @@ -103,7 +103,8 @@ def forward(self, x): | |||
| x = self.dropout_fn(x) | |||
|
|
|||
| # add residual | |||
| if self.nr_blocks_below in {0, self.num_layers - 1}: | |||
| if (self.nr_blocks_below in {0, self.num_layers - 1} and | |||
There was a problem hiding this comment.
And also here just check, self.conv1.in_channels != self.conv2.out_channels?
entropicbloom
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470. Add the 1x1 convolution in a case of different number of channels between input and output of a residual block