Implement assert_implements and assert_implements_optional #22699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See web-platform-tests/rfcs#48 and #21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs.
|
I couldn't figure out if there's a place for unittests for testharness.js that aren't expected to fail. Do we have some somewhere? |
|
(TaskCluster didn't pick up the moving from draft --> review, so close/open to kick it) |
jgraham
reviewed
Apr 7, 2020
|
Ping @jgraham :) |
jgraham
approved these changes
Apr 16, 2020
|
(Sigh, and I forget again that GitHub isn't Gerrit, and doesn't update the commit description with the PR description. It's only slightly inaccurate - commit claims it doesn't port any tests but it actually changes two...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See web-platform-tests/rfcs#48 and
#21971.
Two tests are ported to the new methods to show their use.
Note that this PR does not remove the deprecated
assert_precondition-that will be done in follow-up PRs.