Assisted code review with source{d} lookout
0 likes112 views
The document discusses 'Lookout,' a platform designed for assisted code review, highlighting its machine learning capabilities and integration with Git/GitHub. It covers the architecture, SDKs available, and the ease of writing new analyzers, emphasizing the platform's user-friendly nature. Additionally, it elaborates on different phases of feedback during the coding process, such as IDE, CI, and PR, and contrasts their efficiencies.
![2/4/2019 Assisted Code Review with source{d} Lookout
http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 41/52
High-level API
class MyAnalyzer(Analyzer):
@classmethod
def train(cls, ...) -> AnalyzerModel:
# ...
def analyze(self, ...) -> [Comment]:
# do something with self.model
01.
02.
03.
04.
05.06.
07.](https://image.slidesharecdn.com/assistedcodereviewwithsourcedlookout-190204111437/85/Assisted-code-review-with-source-d-lookout-41-320.jpg)
![2/4/2019 Assisted Code Review with source{d} Lookout
http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 42/52
Train
@with_uasts_and_contents
def train(cls,
ptr: ReferencePointer,
config: Dict[str, Any],
data_service: DataService,
files: Iterable[File]
) -> AnalyzerModel:
01.
02.
03.
04.
05.
06.
07.](https://image.slidesharecdn.com/assistedcodereviewwithsourcedlookout-190204111437/85/Assisted-code-review-with-source-d-lookout-42-320.jpg)
![2/4/2019 Assisted Code Review with source{d} Lookout
http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 43/52
Analyze
@with_changed_uasts_and_contents
def analyze(self,
ptr_from: ReferencePointer,
ptr_to: ReferencePointer,
data_service: DataService,
changes: Iterable[Change]
) -> [Comment]:
01.
02.
03.
04.
05.
06.
07.](https://image.slidesharecdn.com/assistedcodereviewwithsourcedlookout-190204111437/85/Assisted-code-review-with-source-d-lookout-43-320.jpg)
Assisted code review with source{d} lookout
- 1. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 1/52 Assisted Code Review with source{d} Lookout Vadim Markovtsev Machine Learning for Large Scale Code Analysis
- 2. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 2/52 Plan Origins What is Lookout? SDK From scratch: typo correction 1. 2. 3. 4.
- 3. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 3/52 Origins
- 4. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 4/52
- 5. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 5/52
- 6. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 6/52
- 7. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 7/52
- 8. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 8/52
- 9. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 9/52
- 10. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 10/52
- 11. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 11/52 Many efforts target boring stuff
- 12. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 12/52 Boring means automatable
- 13. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 13/52 Automatable ≠ unattended
- 14. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 14/52 When to help? While you type = IDE While you check = CI While you review = PR Periodically, asynchronously = cron • • • •
- 15. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 15/52 IDE Instant feedback Rich information Rich UI Instant feedback Many different IDEs and languages + + + – –
- 16. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 16/52 CI Part of the workflow More time to run No UI Must not be wrong Longer feedback loop + + – – –
- 17. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 17/52 PR reviews Part of the workflow More time to run UI Should not be wrong Longer feedback loop + + + – –
- 18. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 18/52 cron Plenty of time to run Outside of the workflow No UI Longest feedback loop + – – –
- 19. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 19/52 Comparison ∈∈ workflow UI Feedback Rich info FP requirements IDE ✓ ✓✓ instant ✓ low CI ✓ ✗ minutes ✗ 0 PR ✓ ✓ minutes ✗ lowest cron ✗ ✗ hours ✗ low
- 20. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 20/52 When to help? While you type = IDE While you check = CI While you review = PR ← Periodically, asynchronously • • → •
- 21. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 21/52 Welcome to the Codacy Blog Insights for software builders Subscribe
- 22. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 22/52 What is Lookout?
- 23. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 23/52 Goals Assisted code review platform Tight git/GitHub integration Analyzed language agnostic Implementation language agnostic Batteries included • • • • •
- 24. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 24/52 Architecture
- 25. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 25/52 Push event
- 26. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 26/52 Push event
- 27. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 27/52 Push event
- 28. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 28/52 Push event
- 29. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 29/52 Push event
- 30. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 30/52 Push event
- 31. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 31/52
- 32. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 32/52 Push event
- 33. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 33/52 PR event
- 34. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 34/52 PR event
- 35. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 35/52 docs.sourced.tech/lookout
- 36. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 36/52 SDK
- 37. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 37/52
- 38. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 38/52 src-d/lookout-sdk Single source of gRPC definitions Low-level API: Go, Python Low-level examples • • •
- 39. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 39/52 src-d/lookout-sdk-ml High-level Python API Stateful analyzers Integrated with source{d} ml ecosystem • • •
- 40. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 40/52 Rule of
- 41. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 41/52 High-level API class MyAnalyzer(Analyzer): @classmethod def train(cls, ...) -> AnalyzerModel: # ... def analyze(self, ...) -> [Comment]: # do something with self.model 01. 02. 03. 04. 05.06. 07.
- 42. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 42/52 Train @with_uasts_and_contents def train(cls, ptr: ReferencePointer, config: Dict[str, Any], data_service: DataService, files: Iterable[File] ) -> AnalyzerModel: 01. 02. 03. 04. 05. 06. 07.
- 43. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 43/52 Analyze @with_changed_uasts_and_contents def analyze(self, ptr_from: ReferencePointer, ptr_to: ReferencePointer, data_service: DataService, changes: Iterable[Change] ) -> [Comment]: 01. 02. 03. 04. 05. 06. 07.
- 44. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 44/52 Behind the scenes gRPC servers and clients Pooling and threading Database of trained models Caches Logging Metrics • • • • • •
- 45. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 45/52 Hands on
- 46. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 46/52 Objective class Packfile: Review
- 47. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 47/52 Objective def read_packfile(...): # ... class Packfile: Review 01. 02. 03. 04.
- 48. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 48/52 Objective def read_packfile(...): # ... class Packfle: Review 01. 02. 03. 04.
- 49. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 49/52 Steps Install lookout-sdk-ml and autocorrect Write typos.py Fork a repo, create a PR Generate a new GitHub Personal Access Token Run our analyzer 1. 2. 3. 4. 5.
- 50. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 50/52 Summary
- 51. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 51/52 Summary source{d} decided to build products for assisted code review Lookout is a great platform for assisted code review Writing new analyzers is easy and fun • • •
- 52. 2/4/2019 Assisted Code Review with source{d} Lookout http://vmarkovtsev.github.io/mloncode-meetup-2019-webinar/ 52/52 Thank you src-d/lookout src-d/lookout-sdk-ml blog.sourced.tech medium.com/sourcedtech go.sourced.tech/newsletter sourcedtech vadimlearning bit.ly/2H8U5ra