Sprint 146
0 likes153 views
- The sprint review covered enhancements and bug fixes across the UI, providers, platform, and API for ManageIQ in Sprint 146. - Key areas included adding new provisioning fields for IBM Power Virtual Servers, converting the list view to React, and improvements to IBM Cloud and VMware providers. - The platform work focused on CR management and vendor/target platform additions. API improvements allowed PUT/PATCH for zones and reduced N+1 queries. - Questions were invited for the upcoming Sprint 147 review on October 14th.
Sprint 146
- 1. SPRINT 146 REVIEW - Sprint Ending September 28, 2020 September 30, 2020 Meeting Start: 10:30 am EST
- 2. 2 SPEAKERS ● Overview ● UI (Harpreet Kataria) ● Providers (Adam Grare) ● Platform (Joe VLcek) ● API (Alberto Bellotti)
- 3. 3 ManageIQ Jansa GA! ● https://www.manageiq.org/blog/2020/09/manageiq-jansa-ga-announcement/ Now working on ManageIQ Kasparov ● IBM Cloud ● VMware NSX-T ● IBM Terraform ManageIQ Roadmap ● http://manageiq.org/roadmap COMMUNITY
- 4. 4
- 5. 5 * Note that some PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are excluded.
- 6. Core Repositories Repository Files Lines of Code Rating Total Issues Complexity Issues Duplication Issues Bug Risk Issues Style Issues Test Coverage ManageIQ/manageiq 1714 82171 A 1037 466 273 38 260 NA ManageIQ/manageiq-schema 867 18263 B 300 72 198 2 28 82.27 ManageIQ/manageiq-api 251 8606 A 134 21 103 7 3 94.04 ManageIQ/manageiq-ui-classic 2863 123547 C 4907 2318 944 209 612 NA ManageIQ/manageiq-ui-service 404 13106 C 203 179 24 0 0 NA ManageIQ/manageiq-automation_engine 204 8232 C 177 145 23 2 7 85.74 ManageIQ/manageiq-content 1516 9310 B 178 66 98 4 10 97.83
- 7. Provider Repositories Repository Files Lines of Code Rating Total Issues Complexity Issues Duplication Issues Bug Risk Issues Style Issues Test Coverage ManageIQ/manageiq-providers-amazon 127 4677 A 37 5 17 1 14 65.44 ManageIQ/manageiq-providers-ansible_tower 76 1868 A 14 3 9 1 1 83.01 ManageIQ/manageiq-providers-azure 103 3946 A 34 10 15 4 5 74.79 ManageIQ/manageiq-providers-azure_stack 78 1418 A 7 3 0 0 4 NA ManageIQ/manageiq-providers-foreman 56 886 A 11 7 2 0 2 67.24 ManageIQ/manageiq-providers-google 85 1635 A 6 1 2 0 3 79.29 ManageIQ/manageiq-providers-ibm_cloud 91 1542 A 8 1 4 0 3 53.35 ManageIQ/manageiq-providers-ibm_terraform 43 369 A 2 0 0 0 2 75.38 ManageIQ/manageiq-providers-kubernetes 82 4182 A 15 3 8 1 3 75.79 ManageIQ/manageiq-providers-lenovo 114 3690 A 45 3 38 0 4 48.46 ManageIQ/manageiq-providers-nsxt 94 2459 D 72 1 61 0 10 NA ManageIQ/manageiq-providers-nuage 84 1758 A 14 2 11 0 1 90.71 ManageIQ/manageiq-providers-openshift 64 1297 A 6 2 2 1 1 39.65 ManageIQ/manageiq-providers-openstack 208 10887 C 239 131 84 3 21 74.10 ManageIQ/manageiq-providers-ovirt 129 6756 A 39 6 7 0 26 76.18 ManageIQ/manageiq-providers-redfish 71 1165 B 17 0 16 0 1 71.13 ManageIQ/manageiq-providers-scvmm 68 1737 A 13 2 4 0 7 69.87 ManageIQ/manageiq-providers-vmware 165 8413 A 100 40 28 2 30 66.32
- 8. 8 PRs (UI, SUI, UI/REACT Components, API ): PRs (UI, SUI, UI/REACT Components): 29 Bugs: 14, Enhancements: 10, Technical Debt/Refactoring: 3, other: 2 Enhancements ● Added new provisioning fields for the "IBM Power Virtual Servers" Provider (#7297) ● React version of List view (#7188) ● a11y: Make the main menu items accessible using the keyboard (#7315) ● Add description/target platform to Config Profile (#7317) ● Display vendor for configured systems (#7341) ● Display labels for Infra VMs (#7318) Bugs ● Allow the async-credentials component and its children to be not required (#7347) ● Display the buttons' labels on DDF forms properly (#7339) ● Show the helperText on the password-field component properly (#7337) ● Fix issue during return from Set Ownership Screen to summary page of Service (#7316) ● Fix the validation of dependent fields in async credentials component (#7308) ● Correctly set null as default value for null and empty strings (#451) ● Fixed table header shift after icon column was removed from list view (#449) UI (Harpreet Kataria)
- 9. 9 Added new provisioning fields for the "IBM Power Virtual Servers" Provider (#7297) UI (Harpreet Kataria)
- 10. 10 React version of List view (#7188) UI (Harpreet Kataria) Before
- 11. 11 React version of List view (#7188) UI (Harpreet Kataria) After
- 12. 12 Core ● Numerous enhancements and refactorings to the Label-to-Tag Mapper class ○ Extend the current Tag Mapper to be able to be used by any Manager types (#20554) ○ Move the ems_refresh component of the tag mapper into the core Persister class (#20561) ○ And rename it to PersisterTagMapper since it isn’t just for Containers anymore (#20567) IBM Terraform ● Add “target_platform” to configuration profiles (#25) ● Link configured systems to configuration profiles (#29) ● Add “vendor” to configured systems (#30) PROVIDERS (Adam Grare)
- 13. 13 IBM Cloud 24 PRs just in manageiq-providers-ibm_cloud Power Virtual Servers ● Improved provisioning forms (#19) ● Collect assigned virtual cores for instances (#46) ● Collect SystemTypes(Flavors) and CloudVolumeTypes(StorageTypes) for Provisioning (#30) ● Add support for VM (#27), CloudVolume (#34), and Subnet deletion (#35) ● Continue to add spec coverage (#23, #31) PROVIDERS (Adam Grare)
- 15. 15 IBM Cloud Virtual Private Cloud (VPC) ● New cloud provider! (#29) ○ IBM Cloud Virtual Server for VPC - https://www.ibm.com/cloud/vpc ● Lots of refresh enhancements ○ Availability Zones and Key Pairs (#33) ○ Flavors, Security Groups, Cloud Networks and Subnets (#41) ○ Power State Mapping (#42) ○ Floating IPs (#49) ● See #28 for the full roadmap PROVIDERS (Adam Grare)
- 16. 16 VMware vSphere ● Add back collection of CustomizationSpecs (missed in the move to graph refresh) (#614) ● Fix an exception when deleting a Host (#630) ● Added Content Library deploy operation (#617) and Service (#629) ○ See #19718 for the full feature description ● Collect “Tags & Custom Attributes” added in vSphere 6.0 (#626) ○ From the vsphere-automation API ○ These labels also will me mapped to Tags PROVIDERS (Adam Grare)
- 17. 17
- 18. 18
- 19. 19
- 20. 20 14 PRs merged Enhancements: ● Manage the CR and include it in the reconcile loop manageiq-pods/628 ● Add vendor to configured_systems manageiq-schema/515 ● Add target platform to the configuration profiles manageiq-schema/511 ● Add relationship from sessions to users manageiq-schema/503 ● Switch to use rdkafka client manageiq-messaging/54 Bugs: ● Add ManageIQ as the provider of the upstream operator manageiq-pods/631 ● Replace Vim types in CustomizationSpec https://github.com/ManageIQ/manageiq-schema/pull/508 PLATFORM (Joe VLcek)
- 21. 21 ● Allow PUT and PATCH methods for editing Zones (David H.) #897 Now supporting the PUT and PATCH HTTP methods in addition to POST for editing Zones. PATCH /api/zones/2 { “description” : “Test Zone” } API (Alberto Bellotti)
- 22. 22 ● API Performance PRs (Nick L.) #887 #890 The N+1 Squashing journey …. 🏎 - Introspecting virtual attributes for determining what models and relationships can be preloaded in the initial query. - Removes N+1 from subcollection virtual attribute queries Sample queries with improved performance: GET /api/vms?expand=resources&attributes=num_cpu,name GET /api/vms?expand=resources&attributes=hardware.cpu_sockets,name GET /api/vms?expand=resources&attributes=os_image_name,has_rdm_disk,lans,name GET /api/vms?expand=resources&attributes=v_owning_cluster,name API (Alberto Bellotti)
- 23. 23 ● API Performance PRs - Continued (Nick L.) #896 - Fix for proper handling of classes participating in RBAC. - This now adds the ability to specify secondary association attributes via the dot notation Attribute specifications like: operating_system . computer_system . created_at and: hardware . host . name are now possible: GET /api/vms?expand=resources&attributes=operating_system.computer_system.created_at,name GET /api/vms?expand=resources&attributes=hardware.host.name,name API (Alberto Bellotti)
- 24. 24 Questions? Discussion? Sprint 147 Review - October 14 Meeting Start: 10:30 am EST
- 25. THANK YOU manageiq.org github.com/ManageIQ twitter.com/ManageIQ gitter.im/ManageIQ/manageiq facebook.com/manageiq talk.manageiq.org youtube.com/user/ManageIQVideolinkedin.com/company/manageiq