Sprint 189
Download as PPTX, PDF0 likes96 views
This document summarizes the Sprint 189 review meeting for ManageIQ. The main topics discussed were: 1. UI work including 16 PRs focused on bugs and 3 on other tasks. Major bugs addressed were translation issues and fixing missing VMware templates. 2. Provider work including updates to AWS, Azure, Google Cloud, IBM cloud services, Oracle Cloud, Redfish, and VMware. 3. Platform work including enhancing the API and addressing bugs like log decorator failures and JS errors on credential pages. 4. Questions and discussion before concluding the meeting.
![5
UI
(Jeffrey Bonson)
16 PRs (UI, SUI, UI Components): Bugs: 13, Others: 3
Bugs
● Translation Updates (manageiq-ui-classic#8282)
● Fixed pagination translations (manageiq-ui-classic#8286)
● Removing Interpolation across code (i18n) (manageiq-ui-classic#8293)
● June 7th translation bug fixes from core: 21926 (manageiq-ui-classic#8306)
● Updated English oldjs after UI 8293 and Core 21930 (manageiq-ui-classic#8307)
● [NAJDORF] Removing Interpolation across code (i18n) (manageiq-ui-classic#8308)
● Fixed no VMWare templates in Provision Requests (manageiq-ui-classic#8287)
● Fixed catalog item summary page (manageiq-ui-classic#8292)
● Fix vertical label for translated strings for data table (manageiq-ui-classic#8303)
● Fix routes_spec for service report_data (manageiq-ui-classic#8296)
● Allow other Host supports feature calls (manageiq-ui-classic#8298)
● Test host charts with various applies_to_method (manageiq-ui-classic#8309)](https://image.slidesharecdn.com/sprint189-220615135051-a1c147e3/85/Sprint-189-5-320.jpg)
![6
UI
(Jeffrey Bonson)
1. Translation Updates (manageiq-ui-classic#8282)
○ Applied i18n guidelines to strings that were not properly externalized and as such were not being translated.
1. Fixed pagination translations (manageiq-ui-classic#8286)
○ Fixed string translation markings for table pagination.
○ String translation were added to the individual strings inside the function to translate.
1. Removing Interpolation across code (i18n) (manageiq-ui-classic#8293)
○ Removes interpolation across various sections of code as these are not conductive to i18n, leading to problems
with translation.
1. Updated English oldjs after UI 8293 and Core 21930 (manageiq-ui-classic#8307)
○ Includes interpolation and frozen strings mutation fixes from #8293
1. June 7th translation bug fixes from core: 21926 (manageiq-ui-classic#8306)
○ Translation related bugs were made in core which resulted in removal of few files in our classic repository.
1. [NAJDORF] Removing Interpolation across code (i18n) (manageiq-ui-classic#8308)
○ Fixed conflicts from angular conversion that occurred on master but not on najdorf](https://image.slidesharecdn.com/sprint189-220615135051-a1c147e3/85/Sprint-189-6-320.jpg)
Sprint 189
- 1. SPRINT 189 REVIEW - Sprint Ending June 13, 2022 June 15, 2022 Meeting Start: 9:30 am EDT
- 2. 2 SPEAKERS ● Overview (Jason Frey) ● UI (Jeffrey Bonson) ● Providers (Adam Grare) ● Platform (Joe Rafaniello) ● API (Keenan Brock)
- 3. 3
- 4. 4 * Note that some PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are excluded.
- 5. 5 UI (Jeffrey Bonson) 16 PRs (UI, SUI, UI Components): Bugs: 13, Others: 3 Bugs ● Translation Updates (manageiq-ui-classic#8282) ● Fixed pagination translations (manageiq-ui-classic#8286) ● Removing Interpolation across code (i18n) (manageiq-ui-classic#8293) ● June 7th translation bug fixes from core: 21926 (manageiq-ui-classic#8306) ● Updated English oldjs after UI 8293 and Core 21930 (manageiq-ui-classic#8307) ● [NAJDORF] Removing Interpolation across code (i18n) (manageiq-ui-classic#8308) ● Fixed no VMWare templates in Provision Requests (manageiq-ui-classic#8287) ● Fixed catalog item summary page (manageiq-ui-classic#8292) ● Fix vertical label for translated strings for data table (manageiq-ui-classic#8303) ● Fix routes_spec for service report_data (manageiq-ui-classic#8296) ● Allow other Host supports feature calls (manageiq-ui-classic#8298) ● Test host charts with various applies_to_method (manageiq-ui-classic#8309)
- 6. 6 UI (Jeffrey Bonson) 1. Translation Updates (manageiq-ui-classic#8282) ○ Applied i18n guidelines to strings that were not properly externalized and as such were not being translated. 1. Fixed pagination translations (manageiq-ui-classic#8286) ○ Fixed string translation markings for table pagination. ○ String translation were added to the individual strings inside the function to translate. 1. Removing Interpolation across code (i18n) (manageiq-ui-classic#8293) ○ Removes interpolation across various sections of code as these are not conductive to i18n, leading to problems with translation. 1. Updated English oldjs after UI 8293 and Core 21930 (manageiq-ui-classic#8307) ○ Includes interpolation and frozen strings mutation fixes from #8293 1. June 7th translation bug fixes from core: 21926 (manageiq-ui-classic#8306) ○ Translation related bugs were made in core which resulted in removal of few files in our classic repository. 1. [NAJDORF] Removing Interpolation across code (i18n) (manageiq-ui-classic#8308) ○ Fixed conflicts from angular conversion that occurred on master but not on najdorf
- 7. 7 Fixed no VMWare templates in Provision Requests (manageiq-ui-classic#8287) UI (Jeffrey Bonson) There are no VMWare templates in the 'Provision Requests based on the selected Template ' table. Fixed by providing the CloudManager::Template Before After
- 8. 8 Fix vertical label for translated strings for data table (manageiq-ui-classic#8303) UI (Jeffrey Bonson) Translated labels were vertically aligned in data table headers A check was done to display the page by handling a missing data related to providers Before After
- 9. 9 Fixed catalog item summary page (manageiq-ui-classic#8292) UI (Jeffrey Bonson) Before After Catalog was missing before
- 10. 10 Fix routes_spec for service report_data (manageiq-ui-classic#8296) UI (Jeffrey Bonson) Routes
- 11. 11 Allow other Host supports feature calls (manageiq-ui-classic#8298) Test host charts with various applies_to_method (manageiq-ui-classic#8309) UI (Jeffrey Bonson) Storage controller Chart layout service
- 12. 12 Technical Debt 1. Delete transform and mass transform vms (manageiq-ui-classic#8283) 1. Remove old empty charts angular code (manageiq-ui-classic#8288) UI (Jeffrey Bonson)
- 13. 13 Core ● Allow providers to control Host performance CPU charts (#21909) ● Replace Host#validate_ipmi with SupportsFeature (#21915, #21912, #21922) Amazon ● Update AWS instance_types (#776, #777) Azure ● Delegate refresh from NetworkManager to CloudManager (#509) Google ● Update fog-google, googleauth, and google-api-client gems (#214) PROVIDERS (Adam Grare)
- 14. 14 IBM Power Virtual Servers ● Improve Native Console URL (#389) ● Collect Server Placement Groups (#363) ● Add support for clone-to-template provision workflow (#374) IBM Cloud VPC ● Persist the username of user who initiated events (#386) IBM PowerHMC ● Display only CPU usage charts for Hosts (#61) ● Add Power operations for Physical Servers (#58) PROVIDERS (Adam Grare)
- 15. 15 Oracle Cloud ● Add Proxy support for oracle cloud (#65) Ovirt ● Refactor refresher specs using core EmsRefreshHelper (#604) Redfish ● Fix service_url when using ssl-no-validation (#161) VMware ● Set last_refresh_success_date (#808) PROVIDERS (Adam Grare)
- 16. 16 Enhancements ● Add delete_collection API to kubeclient kubeclient#541 ● Service de-exploration schema and features changes: manageiq-schema#648 manageiq#21839 ● Add VMDB::Util.http_proxy method returning a hash manageiq#21895 ● Handle multiple calls to a stubbed supports? method in tests manageiq#21916 PLATFORM (Joe Rafaniello)
- 17. 17 Bugs ● Fix sporadic log_decorator failure due to log.level log_decorator#20 ● Validate alert profile description length manageiq#21921 ● Drop AvailabilityMixin and related code and move towards using supports? manageiq#21890 manageiq#21891 manageiq#21912 manageiq#21915 manageiq#21922 ● Fix cases where return value was neither a widget generation task id nor nil manageiq#21928 ● Fix js console errors on on add/edit of ansible machine credentials manageiq#21927 ● Updated translations and fixes manageiq#21899 manageiq#21910 manageiq#21926 manageiq#21930 ● Enforce minimum rack for CVE-2022-30122 CVE-2022-30123 manageiq#21887 ● Add format docker for s390x builds using podman manageiq-pods#840 PLATFORM (Joe Rafaniello)
- 18. 18 Enhancements ● Task id coming back from widget refresh #1165 API (Keenan Brock)
- 19. 19 Questions? Discussion? Sprint 190 Review - June 29, 2022 Meeting Start: 9:30 am EDT https://zoom.us/j/3660261582?pwd=aGNRYVRFQ3kxWU0rZDNvaUdDS0VmZz09
- 20. THANK YOU manageiq.org github.com/ManageIQ twitter.com/ManageIQ gitter.im/ManageIQ/manageiq facebook.com/manageiq talk.manageiq.org youtube.com/user/ManageIQVideo linkedin.com/company/manageiq
Editor's Notes
- #17: Russell added delete_collection API to kubeclient, such as for calling delete_pods, delete_nodes, etc. to delete all instances of one type in a namespace Jeff added schema and product features changes to enable removing the service/explorer Adam added a convenience method to return the components of a http proxy URI as a hash as some providers need this information and URI parsing information we already have is unnecessary Keenan enhanced our support? Test stubbing to solve a problem for callers who called support? multiple times where they wanted to stub only the first call and subsequent calls would call the original code
- #18: Adam fixed a sporadic test failure due to changes to shared state: the log.level, by resetting the value during the teardown of the test Keenan fixed a problem where we had expectations in the UI regarding an alert profile description’s length by adding an explicit 255 length validation in the model. Keenan continued work on moving from AvailabilityMixin to Supports? He converted the last few remaining uses of the AvailablityMixin and was able to remove it! Adam also updated some of the ipmi checks to use the correct supports? API and before doing ipmi operations. Jason fixed an issue where an async task for widget data already existed and was returning true instead of the existing task id used for tracking task completion. He also fixed another issue that could occur in development with synchronous widget generation. Gilbert fixed an issue where the ansible machine credentials model definition didn’t include the required credential type field Frank, Melody, and I updated the translations to pull in fixes for incorrect strings, strings that weren’t previously exposed for translation, and to update the message catalogs with the latest strings for translation I added a change to enforce a minimum rack version for security fixes. This version was already supported and in use in our builds but wasn’t required. Now, it’s the minimum version. Jason fixed issues where the images created by podman on s390x are not in v2 image format, which causes issues later when creating multi-architecture image manifests.
- #19: The core fix with the task_id from async widget refresh was reflected in the API for widget refresh