Stop doing (bad) code reviews - DevOpsBCN - Apr 2025
- 1. Stop doing (bad) code reviews. Marco Patiño - cofounder at Pullpo.io Insights from a year of research
- 2. How can we consistently ship good code fast?
- 3. How can we consistently ship good code fast? bad slowly
- 4. Code reviews
- 8. Speed *Aggregated data from Pullpo clients during the three months prior to implementing Pullpo’s tools.
- 9. Speed *Aggregated data from Pullpo clients during the three months prior to implementing Pullpo’s tools. idle pick up idle comments idle replies approve idle idle merge x
- 10. Speed Unblocking code reviews idle pick up idle comments idle replies approve idle idle merge x
- 11. Speed Unblocking code reviews Pair programming
- 12. Speed Unblocking code reviews Pair programming Ship/Show/Ask
- 13. Speed Unblocking code reviews Pair programming Ship/Show/Ask
- 14. Speed Unblocking code reviews Pair programming Ship/Show/Ask Do we need a code review for this change?
- 15. Speed Unblocking code reviews Pair programming Ship/Show/Ask
- 16. Speed Unblocking code reviews Pair programming Ship/Show/Ask
- 17. Speed Unblocking code reviews Pair programming Ship/Show/Ask
- 18. Speed Unblocking code reviews Pair programming Ship/Show/Ask Blocking!
- 19. Speed Optimizing code reviews Pickup time, code review time and merge time.
- 20. Speed Optimizing code reviews Pickup time, code review time and merge time.
- 22. Speed Pickup time idle pick up
- 23. Speed Pickup time idle pick up
- 25. Speed Pickup time Codeowners file Simple assignment algorithms: round robin or load balancing idle pick up
- 26. Speed Pickup time Codeowners file Simple assignment algorithms: round robin or load balancing More complex assignment algorithms: knowledge islands, changed files, workload, vacations… idle pick up
- 27. Speed Pickup time Codeowners file Simple assignment algorithms: round robin or load balancing More complex assignment algorithms: knowledge islands, changed files, workload, vacations…
- 28. Speed Code review time idle pick up idle comments idle replies approve idle idle merge x
- 30. Speed Code review time AI Summaries idle comments idle replies approve idle x
- 31. Speed Code review time AI Summaries AI Assistants idle comments idle replies approve idle x
- 32. Speed Code review time AI Summaries AI Assistants Linters idle comments idle replies approve idle x
- 33. Speed Code review time AI Summaries AI Assistants Linters Quality gates idle comments idle replies approve idle x
- 34. Speed Code review time AI Summaries AI Assistants Linters Quality gates Tests idle comments idle replies approve idle x
- 35. Speed Code review time AI Summaries AI Assistants Linters Quality gates Tests Preview environment idle comments idle replies approve idle x
- 36. Speed Code review time Fast code review iterations! idle comments idle replies approve idle x
- 37. Speed Code review time AI Summaries Reply to code review messages Reply to code review messages Preview environment Quality gates AI Assistants
- 38. Speed Code review time idle comments idle replies approve idle x Working on T1 Working on T2 Working on T3 Reviewer makes the comments Reviewer in Slack: “can you please check the comments I made on GitHub”? Replies to comments on the PR
- 40. Speed Code reviews shouldn’t break your flow.
- 46. Quality Quality What is quality in software?
- 47. Quality Quality What is quality in software? ● T ● R ● U ● C ● E
- 48. Quality Quality What is quality in software? ● Timely delivery of features ● R ● U ● C ● E
- 49. Quality Quality What is quality in software? ● Timely delivery of features ● Robustness (reliable, tested, secure, scales, etc.) ● U ● C ● E
- 50. Quality Quality What is quality in software? ● Timely delivery of features ● Robustness (reliable, tested, secure, scales, etc.) ● User needs (meets user requirements/needs) ● C ● E
- 51. Quality Quality What is quality in software? ● Timely delivery of features ● Robustness (reliable, tested, secure, scales, etc.) ● User needs (meets user requirements/needs) ● Collaboration (readable, documented code) ● E
- 52. Quality Quality What is quality in software? ● Timely delivery of features ● Robustness (reliable, tested, secure, scales, etc.) ● User needs (meets user requirements/needs) ● Collaboration (readable, documented code) ● Evolvable design
- 53. How can we consistently ship good code fast?
- 54. How can we consistently ship good code fast? Code reviews Speed Quality Culture
- 55. How can we consistently ship good code fast? Code reviews Speed Quality Culture
- 56. How can we consistently ship good code fast? Code reviews Speed Quality Culture
- 57. How can we consistently ship good code fast? Code reviews Speed Quality Culture
- 58. 👋 I’m Marco! Confounder at Pullpo.io pullpo.to/marco @marcopatino_dev marco@pullpo.io