[Ram] create bulk delete on rules front #144101

guskovaue · 2022-10-27T12:55:09Z

Summary

In this PR I am enabling Delete in menu when Select all is chosen. And trigger new bulk delete API when Delete option will be chosen.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

guskovaue · 2022-10-30T17:20:56Z

@elasticmachine merge upstream

...lugins/triggers_actions_ui/public/application/components/rules_delete_modal_confirmation.tsx

x-pack/plugins/triggers_actions_ui/public/application/lib/rule_api/bulk_delete.ts

...lugins/triggers_actions_ui/public/application/components/rules_delete_modal_confirmation.tsx

x-pack/plugins/triggers_actions_ui/public/application/lib/rule_api/bulk_delete.ts

elasticmachine · 2022-11-01T07:20:36Z

Pinging @elastic/response-ops (Team:ResponseOps)

….com:guskovaue/kibana into RAM-142183-create-bulk-delete-on-rules-front

...lugins/triggers_actions_ui/public/application/components/rules_delete_modal_confirmation.tsx

guskovaue · 2022-11-07T18:20:25Z

@elasticmachine merge upstream

kibanamachine · 2022-11-07T18:20:27Z

merge conflict between base and head

…eate-bulk-delete-on-rules-front

guskovaue · 2022-11-09T08:33:02Z

@elasticmachine merge upstream

kibanamachine · 2022-11-09T08:33:04Z

merge conflict between base and head

kibanamachine · 2022-11-09T08:34:20Z

merge conflict between base and head

…eate-bulk-delete-on-rules-front

guskovaue · 2022-11-11T13:32:28Z

@elasticmachine merge upstream

guskovaue · 2022-11-14T07:17:45Z

@elasticmachine merge upstream

guskovaue · 2022-11-14T09:44:34Z

@elasticmachine merge upstream

….com:guskovaue/kibana into RAM-142183-create-bulk-delete-on-rules-front

XavierM · 2022-11-14T14:12:04Z

@elasticmachine merge upstream

….com:guskovaue/kibana into RAM-142183-create-bulk-delete-on-rules-front

kibana-ci · 2022-11-14T16:08:21Z

💚 Build Succeeded

Buildkite Build
Commit: 5ce201d

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	458	461	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	656.3KB	663.6KB	+7.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	103.7KB	104.0KB	+294.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	59	65	+6
`osquery`	108	113	+5
`securitySolution`	441	447	+6
`triggersActionsUi`	130	132	+2
total			+21

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	67	73	+6
`osquery`	109	115	+6
`securitySolution`	518	524	+6
`triggersActionsUi`	133	135	+2
total			+22

History

💔 Build #87531 failed e14f9bb
💔 Build #87463 failed 825492e
💔 Build #87396 failed dcbe3b8
💔 Build #87361 failed b7c8f78
💔 Build #87278 failed 8ab4d56
💔 Build #87261 failed e0c4cf7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

guskovaue added 4 commits October 26, 2022 08:44

first option of UI

1f354f7

fix bulk delete for rules in management

ecf9651

fix test for rule_quick edit button

1cf2e82

fix existing rules list tests

8a01b18

guskovaue self-assigned this Oct 27, 2022

guskovaue added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0 release_note:enhancement labels Oct 27, 2022

guskovaue added 2 commits October 27, 2022 15:51

small changes in types and naming

a5a3b97

delete comment

debad1b

guskovaue force-pushed the RAM-142183-create-bulk-delete-on-rules-front branch from c982511 to debad1b Compare October 27, 2022 15:33

fix translation error

7ea8df1

guskovaue force-pushed the RAM-142183-create-bulk-delete-on-rules-front branch from b8a1d74 to 7ea8df1 Compare October 28, 2022 18:26

guskovaue added 2 commits October 29, 2022 13:49

fix some functional test

3c929cc

fix details tests

9f36dd2

guskovaue force-pushed the RAM-142183-create-bulk-delete-on-rules-front branch from 58efaff to 9f36dd2 Compare October 30, 2022 15:39

Merge branch 'main' into RAM-142183-create-bulk-delete-on-rules-front

985ba0b

guskovaue changed the title ~~Ram 142183 create bulk delete on rules front~~ [Ram] create bulk delete on rules front Oct 31, 2022

jcger reviewed Oct 31, 2022

View reviewed changes

guskovaue marked this pull request as ready for review November 1, 2022 07:20

guskovaue requested a review from a team as a code owner November 1, 2022 07:20

guskovaue added 4 commits November 1, 2022 09:34

use useCallback instead of arrow functions

4e83940

Merge branch 'RAM-142183-create-bulk-delete-on-rules-front' of github…

08fff99

….com:guskovaue/kibana into RAM-142183-create-bulk-delete-on-rules-front

fix ids type

f51e42a

make translation rerendering

dfb6114

JiaweiWu reviewed Nov 1, 2022

View reviewed changes

...lugins/triggers_actions_ui/public/application/components/rules_delete_modal_confirmation.tsx Outdated Show resolved Hide resolved

guskovaue added 2 commits November 2, 2022 21:09

make delete model component stateless

9510cec

new toast texts

667486e

guskovaue added 3 commits November 8, 2022 09:26

Merge branch 'main' of github.com:guskovaue/kibana into RAM-142183-cr…

3c0a2c8

…eate-bulk-delete-on-rules-front

fix error type

70607c8

fix inconsistencies after ui bumping version

105fb4b

guskovaue added 3 commits November 9, 2022 09:38

Merge branch 'main' of github.com:guskovaue/kibana into RAM-142183-cr…

cea6f68

…eate-bulk-delete-on-rules-front

Merge branch 'main' of github.com:guskovaue/kibana into RAM-142183-cr…

bd59145

…eate-bulk-delete-on-rules-front

fix tests after merge conflict

4c68e8a

guskovaue force-pushed the RAM-142183-create-bulk-delete-on-rules-front branch from f559de8 to 4c68e8a Compare November 10, 2022 15:43

guskovaue added 2 commits November 11, 2022 10:01

fix bulk edit and delete tests

35b90d2

add toast tests

e0c4cf7

Merge branch 'main' into RAM-142183-create-bulk-delete-on-rules-front

8ab4d56

Merge branch 'main' into RAM-142183-create-bulk-delete-on-rules-front

b7c8f78

kibanamachine and others added 3 commits November 14, 2022 04:44

Merge branch 'main' into RAM-142183-create-bulk-delete-on-rules-front

dcbe3b8

delete not used snapshot

d22b0ab

Merge branch 'RAM-142183-create-bulk-delete-on-rules-front' of github…

825492e

….com:guskovaue/kibana into RAM-142183-create-bulk-delete-on-rules-front

jcger approved these changes Nov 14, 2022

View reviewed changes

kibanamachine and others added 3 commits November 14, 2022 09:12

Merge branch 'main' into RAM-142183-create-bulk-delete-on-rules-front

e14f9bb

skip test for rules bulk edit

7455313

Merge branch 'RAM-142183-create-bulk-delete-on-rules-front' of github…

5ce201d

….com:guskovaue/kibana into RAM-142183-create-bulk-delete-on-rules-front

guskovaue merged commit 2b2e1d1 into elastic:main Nov 14, 2022

kibanamachine added the backport:skip This commit does not require backporting label Nov 14, 2022

[Ram] create bulk delete on rules front #144101

[Ram] create bulk delete on rules front #144101

Uh oh!

Conversation

guskovaue commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

guskovaue commented Oct 30, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Nov 1, 2022

Uh oh!

Uh oh!

guskovaue commented Nov 7, 2022

Uh oh!

kibanamachine commented Nov 7, 2022

Uh oh!

guskovaue commented Nov 9, 2022

Uh oh!

kibanamachine commented Nov 9, 2022

Uh oh!

kibanamachine commented Nov 9, 2022

Uh oh!

guskovaue commented Nov 11, 2022

Uh oh!

guskovaue commented Nov 14, 2022

Uh oh!

guskovaue commented Nov 14, 2022

Uh oh!

XavierM commented Nov 14, 2022

Uh oh!

kibana-ci commented Nov 14, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Uh oh!

guskovaue commented Oct 27, 2022 •

edited

Loading