Refactoring - Mejorando el diseño del código existente
Download as PPTX, PDF0 likes572 views
The document provides a collection of Java class definitions and examples focusing on object-oriented programming concepts such as encapsulation, inheritance, and polymorphism. It includes various classes like 'course', 'customer', 'person', and 'employee', highlighting methods for getting and setting properties, as well as implementing interfaces. Additionally, the document illustrates error handling and business logic through examples of withdrawing funds and calculating payment amounts.
![double getValueForPeriod (int periodNumber)
{
try
{
return values[periodNumber];
}
catch (ArrayIndexOutOfBoundsException e)
{
return 0;
}
}
double getValueForPeriod (int periodNumber)
{
if (periodNumber >= values.length) return 0;
return values[periodNumber];
}](https://image.slidesharecdn.com/refactoring-140128123647-phpapp01/85/Refactoring-Mejorando-el-diseno-del-codigo-existente-25-320.jpg)
Refactoring - Mejorando el diseño del código existente
- 1. Mariano Sánchez – Software Architect marianos@lagash.com
- 10. Ejemplo 1: Switch statements
- 11. // set in constructor
- 13. Amphibian
- 14. public class Course { public List students; } int classSize = course.students.size(); public class Course { private List students; public List getStudents() { return students; } public void setStudents(List s) { students = s; } } int classSize = course.getStudents().size();
- 15. public class Customer { private String name; private String workPhoneAreaCode; private String workPhoneNumber; } public class Customer { private String name; private Phone workPhone; } public class Phone { private String areaCode; private String number; }
- 16. public class Customer { private String name; public String getName(){ return name; } public void setName(String string) { name = string; } public String toXML() { return "<Customer><Name>" + name + "</Name></Customer>"; } } public class Customer implements SerXML { private String name; public String getName(){ return name; } public void setName(String string) { name = string; } public String toXML() { return "<Customer><Name>" + name + "</Name></Customer>"; } } public interface SerXml { public abstract String toXML(); }
- 17. public class Customer { void int foo() { … // Compute score score = a*b+c; score *= xfactor; } } public class Customer { void int foo() { … score = ComputeScore(a,b,c,xfactor); } } int ComputeScore(int a, int b, int c, int x) { return (a*b+c)*x; }
- 18. public class Person { private String name; private String jobTitle; } public class Person { protected String name; } public class Employee extends Person { private String jobTitle; }
- 19. public class Employee { private String name; private String jobTitle; } public class Student { private String name; private Course course; } public abstract class Person { protected String name; } public class Employee extends Person { private String jobTitle; } public class Student extends Person { private Course course; }
- 20. public class Company extends Party { public abstract class Party { } private String name; private String companyType; public class Person extends Party private Date incorporated; { public void PrintNameAndDetails() private String firstName; { private String lastName; System.out.println("Name: " + name + " " + private Date dob; companyType); private String nationality; System.out.println("Incorporated: " + public void printNameAndDetails() incorporated.toString()); { } System.out.println("Name: " + firstName + " " + lastName); } System.out.println("DOB: " + dob.toString() + ", Nationality: " + nationality); } }
- 21. public abstract class Party { public void PrintNameAndDetails() { printName(); printDetails(); } public abstract void printName(); public abstract void printDetails(); } public class Company extends Party { private String name; private String companyType; private Date incorporated; public void printDetails() { System.out.println("Incorporated: " + incorporated.toString()); } public void printName() { System.out.println("Name: " + name + " " + companyType); } } public class Person extends Party { private String firstName; private String lastName; private Date dob; private String nationality; public void printDetails() { System.out.println("DOB: " + dob.toString() + ", Nationality: " + nationality); }
- 22. public class Student { public boolean isTaking(Course course) { return (course.getStudents().contains(this)); } } public class Course { private List students; public List getStudents() { return students; } } public class Student { } public class Course { private List students; public boolean isTaking(Student student) { return students.contains(student); } }
- 23. public class User { Plan getPlan() { return plan; } } if (user == null) plan = Plan.basic(); else plan = user.getPlan(); public class User { Plan getPlan() { return plan; } } public class NullUser extends User { Plan getPlan() { return Plan.basic(); } }
- 24. int withdraw(int amount) { if (amount > balance) return -1; else { balance -= amount; return 0; } } void withdraw(int amount) throws BalanceException { if (amount > balance) { throw new BalanceException(); } balance -= amount; }
- 25. double getValueForPeriod (int periodNumber) { try { return values[periodNumber]; } catch (ArrayIndexOutOfBoundsException e) { return 0; } } double getValueForPeriod (int periodNumber) { if (periodNumber >= values.length) return 0; return values[periodNumber]; }
- 26. double getPayAmount() { double result; if (isDead) result = deadAmount(); else { if (isSeparated) result = separatedAmount(); else { if (isRetired) result = retiredAmount(); else result = normalPayAmount(); } } return result; } double getPayAmount() { if (isDead) return deadAmount(); if (isSeparated) return separatedAmount(); if (isRetired) return retiredAmount(); return normalPayAmount(); };
- 27. void setValue (String name, int value) { if (name.equals("height")) { height = value; return; } if (name.equals("width")) { width = value; return; } Assert.shouldNeverReachHere(); } void setHeight(int arg) { height = arg; } void setWidth (int arg) { width = arg; }
- 28. double basePrice = quantity * itemPrice; if (basePrice > 1000) return basePrice * 0.95; else return basePrice * 0.98; ... if (basePrice() > 1000) return basePrice() * 0.95; else return basePrice() * 0.98; double basePrice() { return quantity * itemPrice; }
- 29. public class Customer { public double getinvcdtlmt(); } public class Customer { public double getInvoiceCreditLimit(); }
- 31. Muchas Gracias Mariano Sánchez – Software Architect marianos@lagash.com