Fat query sets and Skinny Models

sunscrapers.comYour favored tech partner.
Thick QuerySets and Thin Models, or
Where to Put Business Logic in
Django
Michał Nakoneczny
2017-05-19

A layer which encodes the real-world business rules that
determine how data can be created, displayed, stored, and
changed.
Business Logic Layer

Idea 1: Fat Models

A Company Blog
class Post(Model):
STATUS_DRAFT, STATUS_APPROVED, STATUS_PUBLISHED = range(3)
STATUS_CHOICES = (
(STATUS_DRAFT, _('Draft')),
(STATUS_APPROVED, _('Approved')),
(STATUS_PUBLISHED, _('Published'))
)
title = models.CharField(max_length=255)
text = models.TextField()
status = models.PositiveSmallIntegerField(
choices=STATUS_CHOICES,
default=STATUS_DRAFT
)

BL: Approving and Publishing
class Post(Model):
...
def approve(self):
self.status = Post.STATUS_APPROVED
self.save()
def publish(self):
if self.status != Post.STATUS_APPROVED:
raise PostInvalidStatusError()
self.status = Post.STATUS_APPROVED
self.save()

Pros:
● Testable;
● Readable;
● DRY?
Cons:
● Unmaintanable in a large code base;
● Leads to unoptimised solutions.
Idea 1: Fat Models

Idea 2: Forms/Views/Serializers

Idea 3: Services

def approve_post(post):
post.status = Post.STATUS_APPROVED
post.save()
def publish_post(post):
if post.status != Post.STATUS_APPROVED:
post.status = Post.STATUS_APPROVED
post.save()

Pros:
● Testable;
● Readable?;
● DRY
Cons:
● Unstructured in a large code base;
● Can lead to unoptimised solutions.
Idea 3: Services

Idea 4: QuerySets/Managers

class PostQuerySet(QuerySet):
def approve(self):
return self.update(status=Post.STATUS_APPROVED)
def publish(self):
return self.filter(status=Post.STATUS_APPROVED).update(
status=Post.STATUS_PUBLISHED)
class Post(Model):
...
objects = PostQuerySet.as_manager()

Pros:
● Testable;
● Readable;
● DRY;
● Optimised (unless you do something stupid).
Cons:
● Checking Business Logic rules is more complicated.
● Integrations get more difficult.
Idea 4: QuerySets/Managers

Business Logic Rules
def publish(self):
return self.filter(status=Post.STATUS_APPROVED).update(
status=Post.STATUS_PUBLISHED)
def publish(self):
if self.exclude(status=Post.STATUS_APPROVED).exists():
return self.update(status=Post.STATUS_PUBLISHED)

Integrations
def pay(self):
Posts_data = …
pay_service = PayService()
try:
pay_service.pay_batch(posts_data)
return self.update (status=Post.STATUS_PAID)
except …:
...

Thanks!
Questions?

Fat query sets and Skinny Models

More Related Content

What's hot (8)

Similar to Fat query sets and Skinny Models (20)

More from Sunscrapers (11)

Recently uploaded (20)

Fat query sets and Skinny Models